Repository navigation
Conversation
A V1 command that timed out on the local channel was retried over MQTT. By then the request had already been published, so the device may have received and run it, and the retry could run a write command (start, set, save map) twice. Only read-only commands (get_*, app_get_*) are now retried after a timeout; others raise RoborockTimeout. Failures before publish still fall back as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a V1 command times out on the local channel,
RpcChannel.send_commandretries it over MQTT. By then the request has already been published, so the device may have received and run it. For a write (app_start,set_*,save_map, ...) the retry can make the device act twice. I saw the local-timeout-then-MQTT resend live on a Saros 20 withget_prop.Change:
_send_rpcraisesRoborockTimeout(aRoborockExceptionsubclass, so existing callers are unaffected) instead of a plainRoborockException.get_*,app_get_*) fall back to the next channel. Other commands raiseRoborockTimeout.Tests: a parametrised case in
tests/devices/rpc/test_v1_channel.pycovers both paths. The write case fails without the change. The rest of the suite is unchanged, and ruff, mypy and codespell pass.AI disclosure: this change was found and written with Claude (Anthropic's AI assistant), then tested before submitting.
🤖 Generated with Claude Code